deps: update c-ares to 1.22.0 #50444

nodejs-github-bot · 2023-10-28T12:42:46Z

This is an automated update of c-ares to 1.22.0.

nodejs-github-bot · 2023-10-28T12:42:50Z

Review requested:

@nodejs/net

update gypfile

targos · 2023-10-28T13:08:44Z

I built it and ran the tests locally. There's a failure:

=== release test-dns-resolveany ===
Path: parallel/test-dns-resolveany
node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected ... Lines skipped

  [
    {
...
    {
      entries: [
+       'v=spf1 ~allxyz\x00foo'
-       'v=spf1 ~all',
-       'xyz\x00foo'
      ],
...
      type: 'CAA'
    }
  ]
    at validateResults (/Users/mzasso/git/nodejs/node/test/parallel/test-dns-resolveany.js:61:10)
    at Socket.<anonymous> (/Users/mzasso/git/nodejs/node/test/parallel/test-dns-resolveany.js:51:3) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [
    { address: '1.2.3.4', ttl: 123, type: 'A' },
    { address: '::42', ttl: 123, type: 'AAAA' },
    { exchange: 'foobar.com', priority: 42, type: 'MX' },
    { value: 'foobar.org', type: 'NS' },
    { entries: [ 'v=spf1 ~allxyz\x00foo' ], type: 'TXT' },
    { value: 'baz.org', type: 'PTR' },
    {
      nsname: 'ns1.example.com',
      hostmaster: 'admin.example.com',
      serial: 156696742,
      refresh: 900,
      retry: 900,
      expire: 1800,
      minttl: 60,
      type: 'SOA'
    },
    { critical: 128, issue: 'platynum.ch', type: 'CAA' }
  ],
  expected: [
    { type: 'A', address: '1.2.3.4', ttl: 123 },
    { type: 'AAAA', address: '::42', ttl: 123 },
    { type: 'MX', priority: 42, exchange: 'foobar.com' },
    { type: 'NS', value: 'foobar.org' },
    { type: 'TXT', entries: [ 'v=spf1 ~all', 'xyz\x00foo' ] },
    { type: 'PTR', value: 'baz.org' },
    {
      type: 'SOA',
      nsname: 'ns1.example.com',
      hostmaster: 'admin.example.com',
      serial: 156696742,
      refresh: 900,
      retry: 900,
      expire: 1800,
      minttl: 60
    },
    { type: 'CAA', critical: 128, issue: 'platynum.ch' }
  ],
  operator: 'deepStrictEqual'
}

Node.js v22.0.0-pre
Command: out/Release/node /Users/mzasso/git/nodejs/node/test/parallel/test-dns-resolveany.js

jasnell · 2023-10-28T15:42:11Z

LGTM once CI failures are resolved

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fixes: nodejs#50741 Refs: nodejs#50444 Fix By: Brad House (@bradh352)

lpinca · 2023-11-18T20:40:41Z

Closed in favor of #50800.

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: nodejs#50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: nodejs#50741 Refs: nodejs#50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: nodejs#50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: nodejs#50741 Refs: nodejs#50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

@bradh352

c-ares has made intentional changes to the behavior of TXT records to comply with RFC 7208, which concatenates multiple strings for the same TXT record into a single string. Multiple TXT records are not concatenated. Also, response handling has changed, such that a response which is completely invalid in formatting is thrown away as a malicious forged/spoofed packet rather than returning EBADRESP. This is one step toward RFC 9018 (EDNS COOKIES) which will require the message to at least be structurally valid to validate against spoofed records. Fix By: Brad House (@bradh352) PR-URL: #50743 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Fixes: #50741 Refs: #50444

deps: update c-ares to 1.21.0

9624633

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Oct 28, 2023

nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Oct 28, 2023

fixup! deps: update c-ares to 1.21.0

0bd1e85

update gypfile

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Oct 28, 2023

jasnell approved these changes Oct 28, 2023

View reviewed changes

richardlau mentioned this pull request Nov 15, 2023

dns test cases failures when upgrading to c-ares 1.21.0/1.22.0 #50741

Closed

bradh352 mentioned this pull request Nov 15, 2023

test: fixes for c-ares update to 1.21.0/1.22.0 #50743

Closed

nodejs-github-bot changed the title ~~deps: update c-ares to 1.21.0~~ deps: update c-ares to 1.22.0 Nov 18, 2023

lpinca closed this Nov 18, 2023

lpinca deleted the actions/tools-update-c-ares branch November 18, 2023 20:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update c-ares to 1.22.0 #50444

deps: update c-ares to 1.22.0 #50444

nodejs-github-bot commented Oct 28, 2023 •

edited

Loading

nodejs-github-bot commented Oct 28, 2023

targos commented Oct 28, 2023

jasnell commented Oct 28, 2023

lpinca commented Nov 18, 2023

deps: update c-ares to 1.22.0 #50444

deps: update c-ares to 1.22.0 #50444

Conversation

nodejs-github-bot commented Oct 28, 2023 • edited Loading

nodejs-github-bot commented Oct 28, 2023

targos commented Oct 28, 2023

jasnell commented Oct 28, 2023

lpinca commented Nov 18, 2023

nodejs-github-bot commented Oct 28, 2023 •

edited

Loading